-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Launchpad Architecture Refactoring #451
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notJoon
changed the title
refactor: launchpad
refactor: Launchpad Architecture Refactoring
Jan 2, 2025
dongwon8247
reviewed
Jan 5, 2025
r3v4s
reviewed
Jan 6, 2025
r3v4s
reviewed
Jan 6, 2025
r3v4s
reviewed
Jan 6, 2025
r3v4s
reviewed
Jan 6, 2025
r3v4s
reviewed
Jan 6, 2025
r3v4s
reviewed
Jan 6, 2025
r3v4s
reviewed
Jan 6, 2025
r3v4s
reviewed
Jan 6, 2025
r3v4s
reviewed
Jan 6, 2025
r3v4s
reviewed
Jan 6, 2025
r3v4s
reviewed
Jan 6, 2025
r3v4s
reviewed
Jan 6, 2025
r3v4s
reviewed
Jan 6, 2025
launchpad/tests/__TEST_launchpad_deposit_project_single_recipient_test.gnoA
Show resolved
Hide resolved
r3v4s
reviewed
Jan 6, 2025
r3v4s
previously approved these changes
Jan 6, 2025
r3v4s
reviewed
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left few comments.
- FYI, I'm aware of feat: add reward cacheing logic to launchpad and governance #455 going on.
- If there are plan to fix things in feat: add reward cacheing logic to launchpad and governance #455, reply it in conversation please.
onlyhyde
previously approved these changes
Jan 19, 2025
jinoosss
previously approved these changes
Jan 19, 2025
Quality Gate passedIssues Measures |
jinoosss
approved these changes
Jan 19, 2025
onlyhyde
approved these changes
Jan 19, 2025
moul
pushed a commit
that referenced
this pull request
Jan 20, 2025
* chore: remove function prefix from panic msg * save * save * test: reward handler * feat: deposit handler * fix error * reward distributor * update test * update docs * fix * refactor deposit, launchpad, reward * reduce type size * fix rpc * refactor: error message * fix * fix * test: json builder * update deposit test * test: reward * fix * add launchpad new logic * catch compile errors * fix: weird interface nil error * refactor: reward empty * fix: when collecting deposit, check claimable Time (not ended height) * test: fix * test: fix MultipleDeposit * test: fix TestValidateRewardCollection - no such error * resolved some comments * remove unnecessary things * remove unnecessary json builder functuion * refactor: event message * update launchpad test * fix: reward_calculation * remove dummy_test file * additional refactor for `CreateProject` * fix: prevent throwing nil deref error in `CollectRewardByProjectId` * validate json creation * save * fix fee protocol * remove: token register * fix compile error for reward03 test * paritally fix: `CollectRewardByProjectId` -- update `RewardState` * fix * refactor: clean code and add comments for functions * test: reward calculation * update reward test * refactor: deposit refactoring * refactor: create project * refactor: deposit * refactor: reward by projectId * refactor: deposit and reward * refactor: left reward * refactor: reward test * refactor: move test code into test folder * refactor: remove unused code * chore: remove some comments * chore: remove comments * remove: hard-coded string * remove: invalid comments * fix: check duplicate collect gns --------- Co-authored-by: 0xTopaz <[email protected]> Co-authored-by: mconcat <[email protected]> Co-authored-by: n3wbie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a comprehensive refactoring of the Launchpad contract architecture, focusing on optimizing reward calculations and improving data structure efficiency. The main goals are to reduce computational overhead, enhance gas efficiency, and improve the overall maintainability of the codebase.
Key Changes
Architectural Improvements
ProjectInput
,ProjectTierInfo
,DepositState
)Code Structure
Major Refactored Components
Project Management (
launchpad_init.gno
->launchpad.gno
)validateProjectInput
createTier
Reward Handling (
launchpad_reward.gno
->reward.gno
)Deposit Management (
launchpad_deposit.gno
)DepositState
for better state managementvalidateDepositCollection
)Simplified and More Organized Types
TimeInfo
: Consolidated height and timestamp pairsProjectStats
: Grouped project statistics fieldsRefundInfo
: Consolidated refund-related fieldsProject Structure Improvements
Project
struct for better maintainability:map[uint64]Tier
)tiersRatios
map for cleaner ratio managementTimeInfo
ProjectStats
RefundInfo
Benefits of New Structure
Memory Optimization
Performance Considerations
Future Improvements